fix: fixing multiselect issue in table

[macci001]

Closes #4252

📝 Description

PR fixes the multiselect issue on table.

⛳️ Current behavior (updates)

Screen.Recording.2024-12-09.at.7.20.29.PM.mov

🚀 New behavior

Screen.Recording.2024-12-09.at.7.19.23.PM.mov

💣 Is this a breaking change (Yes/No): NO\o

📝 Additional Information

Summary by CodeRabbit

• Bug Fixes

  • Resolved multiselect functionality issue in the table component.

• New Features

  • Added an onClick event handler to the TableRow component to enhance interaction by preventing default click behavior.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2480139

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/table	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 9, 2024 1:51pm
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 9, 2024 1:51pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a patch for the @nextui-org/table package that addresses a multiselect issue identified in issue #4252. It adds an onClick event handler to the TableRow component to prevent default actions when rows are clicked, enhancing the interaction for selecting rows via checkboxes in a multiple selection mode.

Changes

File	Change Summary
.changeset/funny-spoons-drop.md	Patch applied for @nextui-org/table addressing multiselect issue.
packages/components/table/src/table-row.tsx	Added onClick event handler to TableRow component to prevent default action on click.

Assessment against linked issues

Objective	Addressed	Explanation
Fix the issue where clicking checkboxes in multiple selection mode does not select the row. (#4252)	✅

Possibly related PRs

• fix(components): improve RTL support for table component #2097: Improves RTL support for the table component, potentially relevant to multiselect functionality.
• fix(table): differentiate selected bg color from striped bg color #3221: Differentiates selected background colors in the table component, related to multiselect functionality.
• fix(select): prevent select from closing instantly when clicking on label of select #3568: Addresses label placement in the select component, closely related to the multiselect feature.
• fix(select): label placement discrepancy in Select #3853: Modifies label placement in the Select component, relevant to the multiselect functionality.
• fix(theme): fixing the label placement in select and input #3869: Fixes label placement in select and input components, pertinent to enhancing multiselect user interface consistency.

Suggested labels

👀 Status: In Review

Suggested reviewers

• wingkwong
• jrgarciadev

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3d782a2 and 2480139.

📒 Files selected for processing (2)

• .changeset/funny-spoons-drop.md (1 hunks)
• packages/components/table/src/table-row.tsx (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jrgarciadev]

Suggested change

	onClick={(e) => {
	e.preventDefault();
	}}
	onClick={(e) => {
	e.preventDefault();
	onClick?.()
	}}

[ankit-ml12]

@macci001 @jrgarciadev good to see this start working.
Just wanted to ask how it started working by just adding this code

I also try and spend 2 hour to resolve this issue but unable to figure out any solution.

Please help me, this learning will help me to contribute in future

[macci001]

Will be handled by: pr4274