Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): correct the style of radio in invalid and selected states #1668

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix(radio): correct the style of radio in invalid and selected states #1668

merged 2 commits into from
Sep 22, 2023

Conversation

bobbychan
Copy link
Contributor

@bobbychan bobbychan commented Sep 21, 2023

Closes #

📝 Description

radio-group

When Radio is selected in invalid state, the border of the Radio controller should be danger color

isInvalid: {
  true: {
    control: "bg-danger text-danger-foreground",
    // data-[selected=true]:border-danger -> group-data-[selected=true]:border-danger
    wrapper: "border-danger data-[selected=true]:border-danger", 
    label: "text-danger",
    description: "text-danger-300",
  },
},

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023

🦋 Changeset detected

Latest commit: 63aab92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/radio Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 21, 2023

@bobbychan is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 3:08pm

"@nextui-org/radio": patch
---

correct the style of radio in invalid and selected states
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using the word "correct" can you describe the change?

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @bobbychan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants