Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): extend variants function, destructuring order changed #1642

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

jrgarciadev
Copy link
Member

@jrgarciadev jrgarciadev commented Sep 16, 2023

Closes #1541

📝 Description

When using extendVariants to inherit components, if defaultVariants is set, it cannot be overridden.

⛳️ Current behavior (updates)

When using extendVariants to inherit components, if defaultVariants is set, it cannot be overridden.

🚀 New behavior

extendVariants function gives more priority to final component props over the extendVariants props

💣 Is this a breaking change (Yes/No): No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023

🦋 Changeset detected

Latest commit: cca0f99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@nextui-org/system-rsc Patch
@nextui-org/badge Patch
@nextui-org/code Patch
@nextui-org/divider Patch
@nextui-org/kbd Patch
@nextui-org/skeleton Patch
@nextui-org/spacer Patch
@nextui-org/spinner Patch
@nextui-org/system Patch
@nextui-org/react Patch
@nextui-org/card Patch
@nextui-org/accordion Patch
@nextui-org/listbox Patch
@nextui-org/menu Patch
@nextui-org/table Patch
@nextui-org/button Patch
@nextui-org/select Patch
@nextui-org/avatar Patch
@nextui-org/checkbox Patch
@nextui-org/chip Patch
@nextui-org/dropdown Patch
@nextui-org/image Patch
@nextui-org/input Patch
@nextui-org/link Patch
@nextui-org/modal Patch
@nextui-org/navbar Patch
@nextui-org/pagination Patch
@nextui-org/popover Patch
@nextui-org/progress Patch
@nextui-org/radio Patch
@nextui-org/ripple Patch
@nextui-org/scroll-shadow Patch
@nextui-org/snippet Patch
@nextui-org/switch Patch
@nextui-org/tabs Patch
@nextui-org/tooltip Patch
@nextui-org/user Patch
@nextui-org/aria-utils Patch
@nextui-org/framer-transitions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 9:05pm
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 9:05pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using extendVariants to inherit components, if defaultVariants is set, it cannot be overridden.
1 participant