Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): selectedKeys added to the values memo function #1639

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

jrgarciadev
Copy link
Member

@jrgarciadev jrgarciadev commented Sep 16, 2023

Closes #1402

⛳️ Current behavior (updates)

Accordion is not working with controlled values

🚀 New behavior

Accordion works with controlled values selectedKeys

💣 Is this a breaking change (Yes/No): No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023

🦋 Changeset detected

Latest commit: c48950b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/accordion Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 7:45pm
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 7:45pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Accordion doesn't handle selectedKeys changes
1 participant