dicts as claim content #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also accepting plain strings as claim keys everywhere now. Goal is to have a single point for reading and writing claims so changes to encoding and content do not need to be applied in multiple places. Currently the plan is to have plain string keys and json encoded values
use read_claim(x, reader=...) and read_claim(x, chain=...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards #7.
Also simplified the cc Account api a bunch by turning
has_readable_claim,has_readable_claim_forandread_claim_from,read_claim_asintoread_claim(key, chain=chain, reader=reader)