-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Batch NOT_FOUND error management #5690
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Should @ejseqera run stress test on this? |
I'm on it |
@jorgee I know we just discussed on it on the call, but can we confirm that this PR also handles these states please?
Thanks! |
I can't see these states in the Google Batch API |
#4537 is a different issue |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@jorgee New issue reported: Nextflow to gracefully handle Google gRPC API call failures |
This PR includes a possible fix for the NotFoundException returned by the Google Batch API when getting some tasks.
When the client.getTaskStatus throws a NotFoundException it is caught and managed in the following way:
Including a unit test producing the NotFoundException to validate the logic.
Two corner cases could not be correctly managed.