Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 RELEASE: v0.11.0 #156

Merged
merged 1 commit into from
Oct 10, 2020
Merged

🚀 RELEASE: v0.11.0 #156

merged 1 commit into from
Oct 10, 2020

Conversation

violoncelloCH
Copy link
Member

@violoncelloCH violoncelloCH commented Oct 4, 2020 •
edited
Loading

and make the app compatible to Nextcloud Hub 20

please review @nextcloud/user_external

@violoncelloCH violoncelloCH added this to the 0.11 milestone Oct 4, 2020
@nickvergessen
Copy link
Member

So in theory because you drop an old version, you should bump the major version.
Since you are below 1.0 it doesn't matter too much, but a 1.0 makes sense too, i eould go for it.

@violoncelloCH
Copy link
Member Author

violoncelloCH commented Oct 4, 2020 •
edited
Loading

I don't really want to take the responsibility to promote this as "stable" all of a sudden, but I guess it makes sense... let me update it...

@violoncelloCH
🚀 RELEASE: v1.0.0
651fb9f 
Signed-off-by: Jonas Sulzer <[email protected]>
@ChristophWurst
Copy link
Member

Major in pre-1.0 basically means a minor bump. It's like major.minor.patch after 1.0 but 0.major.minor before that 😉

But at some point it makes sense to call this a v1.0.

@Aaron-Ritter Aaron-Ritter mentioned this pull request Oct 6, 2020
Closed
@violoncelloCH
Copy link
Member Author

Could we get this in, so the app doesn't get deactivated during an update to 20?

@violoncelloCH violoncelloCH merged commit 8a4e57b into master Oct 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the release/0.11.0 branch October 10, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@kosli kosli Awaiting requested review from kosli

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@nerdmaennchen nerdmaennchen Awaiting requested review from nerdmaennchen

@sebastiansterk sebastiansterk Awaiting requested review from sebastiansterk

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@violoncelloCH @nickvergessen @ChristophWurst