Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.php to allow users to just copy paste the line on the co… #592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waazdakka
Copy link

…nfig.php file

The initial syntax used double quotes and two points which is not the correct syntax in the config.php file instead of simple quote and "=>". This proposition to allow users to just copy paste the line into their config.php file

…nfig.php file

The initial syntax used double quotes and two points which is not the correct syntax in the config.php file instead of simple quote and "=>".
This proposition to allow users to just copy paste the line into their config.php file

Signed-off-by: waazdakka <[email protected]>
@waazdakka waazdakka requested a review from Altahrim as a code owner December 15, 2024 17:24
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Just one change required: The index.php doesn't get modified directly. So this edit needs to be made in index.web.php instead of index.php (then run make index.php).

[The index.php file is a byproduct of the build process and the change show up in there after.]

If you want I can do it for you (not sure if you have an actual dev environment setup for the updater or not).

@joshtrichards joshtrichards added this to the Nextcloud 31 milestone Dec 24, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants