-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE11 madness #1035
Merged
Merged
IE11 madness #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we need to keep up with each dependency if it is actually IE11 compatible Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
skjnldsv
approved these changes
Sep 12, 2020
Tests needs adjustments as well:
|
I can not add anything valuable, so I will just leave this here (and I can not believe that @skjnldsv has not done it yet): |
sooo 18.0.10? or...? |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]> Bump bundles Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
backport/stable18/1032
branch
from
September 29, 2020 07:28
35a5777
to
d814b4f
Compare
Yes, please. Rebased and updated bundles |
Signed-off-by: Julius Härtl <[email protected]>
Cypress failure currently expected |
rullzer
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prosemirror-model
where"block+".split(/\s*(?=\b|\W|$)/)
would return["b", "l", "o", "c", "k", "+"]
instead of["block+"]
However the exact same version combinations work fine on master, so I assume there are some wild polyfills overriding each other
Related issue for core-js zloirock/core-js#810