Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): Fixed typo #1401

Merged
merged 4 commits into from
Oct 26, 2023
Merged

fix(i18n): Fixed typo #1401

merged 4 commits into from
Oct 26, 2023

Conversation

rakekniven
Copy link
Member

No description provided.

Signed-off-by: rakekniven <[email protected]>
Signed-off-by: rakekniven <[email protected]>
@SystemKeeper
Copy link
Collaborator

Thanks @rakekniven !
I’ll take a look later to make CI happy :)

Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many people does it take to add a character 🙈

@SystemKeeper SystemKeeper merged commit afe5028 into master Oct 26, 2023
6 checks passed
@SystemKeeper SystemKeeper deleted the rakekniven-patch-1 branch October 26, 2023 08:11
@rakekniven
Copy link
Member Author

How many people does it take to add a character 🙈

Fixing such typos isn't fun at all.
I do not blame anyone. We are humans and we make errors.
I am hoping to have an automatic spellchecker at GitHub soon.
Having that at Transifex is too late in the whole chain.

@SystemKeeper
Copy link
Collaborator

I wrote this comment, because my fix commit was not correct (looks like on the latest MacOS there's an encoding change), so Ivan committed again to fix the CI.

Fixing such typos isn't fun at all.

Is there anything we can help with that in regards to talk-ios? For us it's usually quite easy, because we generate the localizable files with a script (if you're using a mac yourself, see the generate-localizable-strings-file.sh script) and only need to adjust the source.

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants