Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(guests): Don't force remove guests but leave it to the "purge logic" #13980

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(guests): Don't force remove guests but leave it to the "purge logic" #13980

merged 1 commit into from
Dec 11, 2024
+1 −10

Conversation

nickvergessen
Copy link
Member

Currently guests with a display name are not cleaned up, to keep their name for chat messages and other activity.

👣 Steps

  1. Set up HPB
  2. Create a conversation with public access
  3. Join as a guest and set a name
  4. Write a message
  5. Reload the page
  6. Check if the message from 4 still has the display name
x Firefox Chrome
Before ✅ ❌
After ✅ ✅

The main difference is that Firefox seems to keep the session and is still recognized as the previous guest, chrome creates a new attendees entry on each reload

🛠️ API Checklist

  • As this is the reaction to a request from the HPB no suitable test can be written.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: signaling 📶 Internal and external signaling backends labels Dec 11, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Dec 11, 2024
@nickvergessen nickvergessen self-assigned this Dec 11, 2024
@nickvergessen
fix(guests): Don't force remove guests but leave it to the "purge logic"
b19d269 
Currently guests with a display name are not cleaned up, to keep
their name for chat messages and other activity.

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/noid/dont-force-remove-guests branch from 5c062e7 to b19d269 Compare December 11, 2024 11:22
@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen
Copy link
Member Author

/backport to stable28

Antreesy
Antreesy approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@nickvergessen nickvergessen merged commit ac7f14f into main Dec 11, 2024
75 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/dont-force-remove-guests branch December 11, 2024 14:59
This was referenced Dec 11, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @miaulalala @Antreesy