Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(call): Direct endpoint to check if call notification should be dismissed #13930

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 2, 2024

πŸ› οΈ API Checklist

Just as I was about to send this PR, I remembered that we built https://github.com/nextcloud/notifications/blob/master/openapi.json#L742-L748
That should be sufficient here as well.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

@nickvergessen nickvergessen marked this pull request as draft December 2, 2024 21:54
@nickvergessen nickvergessen force-pushed the feat/noid/call-notification-check-api branch from e295adb to 15f3e34 Compare December 3, 2024 06:01
docs/capabilities.md Outdated Show resolved Hide resolved
lib/Controller/CallNotificationController.php Outdated Show resolved Hide resolved
lib/Service/ParticipantService.php Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the feat/noid/call-notification-check-api branch from 15f3e34 to de23b4b Compare December 4, 2024 06:49
@nickvergessen nickvergessen self-assigned this Dec 4, 2024
@nickvergessen nickvergessen marked this pull request as ready for review December 4, 2024 08:26
@nickvergessen nickvergessen force-pushed the feat/noid/call-notification-check-api branch from f1ecc18 to 55ff1ef Compare December 5, 2024 07:49
}

$status = match($this->participantService->checkIfUserIsMissingCall($token, $this->userId)) {
self::CASE_PARTICIPANT_JOINED,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to not handle this as an error (case if participant joined same call from this or another client). Can we return 202 Accepted or 204 No Content?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the office, I went for an error, as basically 2xx means: keep a notification (of either kind, call or missed), and 4xx means: remove the notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: πŸ—οΈ In progress
Development

Successfully merging this pull request may close these issues.

4 participants