-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(call): Direct endpoint to check if call notification should be dismissed #13930
base: main
Are you sure you want to change the base?
Conversation
e295adb
to
15f3e34
Compare
15f3e34
to
de23b4b
Compare
β¦ismissed Signed-off-by: Joas Schilling <[email protected]>
f1ecc18
to
55ff1ef
Compare
} | ||
|
||
$status = match($this->participantService->checkIfUserIsMissingCall($token, $this->userId)) { | ||
self::CASE_PARTICIPANT_JOINED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to not handle this as an error (case if participant joined same call from this or another client). Can we return 202 Accepted
or 204 No Content
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the office, I went for an error, as basically 2xx means: keep a notification (of either kind, call or missed), and 4xx means: remove the notification
π οΈ API Checklist
Just as I was about to send this PR, I remembered that we built https://github.com/nextcloud/notifications/blob/master/openapi.json#L742-L748
That should be sufficient here as well.
π Checklist
docs/
has been updated or is not required