feat(call): Direct endpoint to check if call notification should be dismissed #13930
+694
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
feat/noid/call-notification-check-api
branch
from
e295adb
to
15f3e34
Compare
miaulalala
requested changes
Dec 3, 2024
nickvergessen
force-pushed
the
feat/noid/call-notification-check-api
branch
from
15f3e34
to
de23b4b
Compare
nickvergessen
added
3. to review
enhancement
feature: api 🛠️
SystemKeeper
reviewed
Dec 4, 2024
…ismissed Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feat/noid/call-notification-check-api
branch
from
f1ecc18
to
55ff1ef
Compare
miaulalala
approved these changes
Dec 5, 2024
Antreesy
reviewed
Dec 5, 2024
| } | ||
|
|
||
| $status = match($this->participantService->checkIfUserIsMissingCall($token, $this->userId)) { | ||
| self::CASE_PARTICIPANT_JOINED, |
There was a problem hiding this comment.
I'd like to not handle this as an error (case if participant joined same call from this or another client). Can we return 202 Accepted or 204 No Content?
There was a problem hiding this comment.
As mentioned in the office, I went for an error, as basically 2xx means: keep a notification (of either kind, call or missed), and 4xx means: remove the notification
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ API Checklist
Just as I was about to send this PR, I remembered that we built https://github.com/nextcloud/notifications/blob/master/openapi.json#L742-L748
That should be sufficient here as well.
🏁 Checklist
docs/has been updated or is not required