Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SIP): get dial-in info from signaling settings #13928

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(SIP): get dial-in info from signaling settings #13928

wants to merge 1 commit into from
+42 −38

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 2, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🚧 Tasks

  • Make _trigger() work when initially create from Signaling

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review feature: signaling 📶 Internal and external signaling backends technical debt labels Dec 2, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Dec 2, 2024
@Antreesy Antreesy requested a review from ShGKme December 2, 2024 16:18
@Antreesy Antreesy self-assigned this Dec 2, 2024
@Antreesy Antreesy force-pushed the fix/13904/get-dial-in-from-signaling branch from a24667f to ad41a2a Compare December 3, 2024 09:25
@Antreesy Antreesy marked this pull request as ready for review December 3, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
3. to review feature: signaling 📶 Internal and external signaling backends technical debt
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Read SIP dial information from signaling settings instead of initial state
1 participant
@Antreesy