Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessagesList): prevent scroll position changes based on messages … #13244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DorraJaouad
Copy link
Contributor

…height when user is scrolling down.

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

In progress..

🏚️ Before 🏡 After
Screenshot before Screenshot after

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

…height when user is scrolling down.

Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad DorraJaouad added this to the 🖤 Next Major (31) milestone Sep 9, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy September 9, 2024 21:04
@DorraJaouad DorraJaouad self-assigned this Sep 9, 2024
@DorraJaouad
Copy link
Contributor Author

Just for the record:

While debugging I noticed other issues:

  1. Scroll to bottom not completed sometimes: We have many things that can load while it is scrolling down, and from the time the scroll is triggered, the height has changed, so it will scroll to the previous height and not to post-loading height.
    Possible solution: recursive scroll position check to keep scrolling until bottom is reached

  2. Scrolling through a long list of unread messages: When joining conversation and we have more than 50 unread messages, we don't actually fetch all of them, during scroll to bottom, we keep fetching, which leads to just scrolling through the initial batch, then user has to press scroll to bottom again to scroll to the next one.
    Possible solution: maybe the same as 1. ?

P.S: we need a summary of scroll handling there so we stay aware of restrictions and limitations :')

@SystemKeeper
Copy link
Contributor

I think we have the same problem when you click on a quote an we have to scroll upwards ?

@SystemKeeper
Copy link
Contributor

I think we have the same problem when you click on a quote an we have to scroll upwards ?

It also happens when you open a link to a message and we try to scroll to that message. We end up "somewhere near" that message in most cases.

@Antreesy
Copy link
Contributor

With 917358d in mind we can use current direction to decide, whether we perform this additional scroll up/down or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Scroll to bottom" does not scroll all the way
3 participants