feat(polls): allow editing of draft polls #21596
miaulalalapsalm.yml
on: pull_request
static-psalm-analysis
57s
Annotations
3 errors and 1 warning
|
InvalidReturnStatement:
lib/Federation/Proxy/TalkV1/Controller/PollController.php#L207
lib/Federation/Proxy/TalkV1/Controller/PollController.php:207:11: InvalidReturnStatement: The inferred type 'OCP\AppFramework\Http\DataResponse<200, array{actorDisplayName: string, actorId: non-empty-string, actorType: 'bots'|'bridged'|'circles'|'emails'|'federated_users'|'groups'|'guests'|'phones'|'users', details?: list<array{actorDisplayName: string, actorId: string, actorType: string, optionId: int}>, id: int<1, max>, maxVotes: int<0, max>, numVoters?: int<0, max>, options: list<string>, question: non-empty-string, resultMode: 0|1, status: 0|1|2, votedSelf?: list<int>, votes?: array<string, int>}, array<never, never>>' does not match the declared return type 'OCP\AppFramework\Http\DataResponse<200|400, array{actorDisplayName?: string, actorId?: non-empty-string, actorType?: 'bots'|'bridged'|'circles'|'emails'|'federated_users'|'groups'|'guests'|'phones'|'users', error?: 'draft'|'options'|'question'|'room', id?: int<1, max>, maxVotes?: int<0, max>, options?: list<string>, question?: non-empty-string, resultMode?: 0|1, status?: 0|1|2}, array<never, never>>' for OCA\Talk\Federation\Proxy\TalkV1\Controller\PollController::updateDraftPoll (see https://psalm.dev/128)
|
|
InvalidReturnStatement:
lib/Federation/Proxy/TalkV1/Controller/PollController.php#L209
lib/Federation/Proxy/TalkV1/Controller/PollController.php:209:10: InvalidReturnStatement: The inferred type 'OCP\AppFramework\Http\DataResponse<200, array{actorDisplayName: string, actorId: non-empty-string, actorType: 'bots'|'bridged'|'circles'|'emails'|'federated_users'|'groups'|'guests'|'phones'|'users', details?: list<array{actorDisplayName: string, actorId: string, actorType: string, optionId: int}>, id: int<1, max>, maxVotes: int<0, max>, numVoters?: int<0, max>, options: list<string>, question: non-empty-string, resultMode: 0|1, status: 0|1|2, votedSelf?: list<int>, votes?: array<string, int>}, array<never, never>>' does not match the declared return type 'OCP\AppFramework\Http\DataResponse<200|400, array{actorDisplayName?: string, actorId?: non-empty-string, actorType?: 'bots'|'bridged'|'circles'|'emails'|'federated_users'|'groups'|'guests'|'phones'|'users', error?: 'draft'|'options'|'question'|'room', id?: int<1, max>, maxVotes?: int<0, max>, options?: list<string>, question?: non-empty-string, resultMode?: 0|1, status?: 0|1|2}, array<never, never>>' for OCA\Talk\Federation\Proxy\TalkV1\Controller\PollController::updateDraftPoll (see https://psalm.dev/128)
|
|
static-psalm-analysis
Process completed with exit code 2.
|
|
static-psalm-analysis
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|