Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app nav img margin #6623

Merged
merged 3 commits into from
Sep 24, 2017
Merged

Fix app nav img margin #6623

merged 3 commits into from
Sep 24, 2017

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 23, 2017

Fix #6622
@nextcloud/designers

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. regression labels Sep 23, 2017
@skjnldsv skjnldsv self-assigned this Sep 23, 2017
@juliusknorr
Copy link
Member

@skjnldsv Also happens to be an issue without an image, see the app management:

bildschirmfoto vom 2017-09-23 14-30-02

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 23, 2017

@juliushaertl This is @jancborchardt's will. He wants users to be 'forced' to have some icons! :)
#6399 (comment)

@juliusknorr
Copy link
Member

Ah ok, is there already an issue for the parts missing an icon in the server repo?

@skjnldsv
Copy link
Member Author

You mean in the apps management section?

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@codecov
Copy link

codecov bot commented Sep 23, 2017

Codecov Report

Merging #6623 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6623      +/-   ##
============================================
- Coverage     53.06%   53.06%   -0.01%     
  Complexity    22553    22553              
============================================
  Files          1414     1414              
  Lines         87745    87745              
  Branches       1340     1340              
============================================
- Hits          46565    46564       -1     
- Misses        41180    41181       +1
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)

@skjnldsv
Copy link
Member Author

@nextcloud/designers please review :)

@juliusknorr
Copy link
Member

@skjnldsv Yes. Found it #3987

@rullzer rullzer merged commit 24a881f into master Sep 24, 2017
@rullzer rullzer deleted the fix-app-nav-img branch September 24, 2017 11:07
@jancborchardt
Copy link
Member

@skjnldsv see, it pushes us to add icons ;)

@skjnldsv
Copy link
Member Author

@jancborchardt well done fine sir! You tricked me well! 😱😱

@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants