Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(cypress): flaky live photo test grid_view trigger issue #50027

Merged
merged 1 commit into from
Jan 7, 2025
+7 −3
Merged

[stable29] fix(cypress): flaky live photo test grid_view trigger issue #50027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/cypress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,10 @@ jobs:
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
if: always()
with:
name: snapshots_${{ matrix.containers }}
path: cypress/snapshots
name: snapshots_videos_${{ matrix.containers }}
path: |
cypress/snapshots
cypress/videos

- name: Extract NC logs
if: failure() && matrix.containers != 'component'
Expand Down
4 changes: 3 additions & 1 deletion cypress.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ export default defineConfig({
// Needed to trigger `after:run` events with cypress open
experimentalInteractiveRunEvents: true,

// disabled if running in CI but enabled in debug mode
video: !process.env.CI || !!process.env.RUNNER_DEBUG,

// faster video processing
video: !process.env.CI,
videoCompression: false,

// Prevent elements to be scrolled under a top bar during actions (click, clear, type, etc). Default is 'top'.
Expand Down
Loading