-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: make taskprocessing task types toggleable #49727
base: master
Are you sure you want to change the base?
Conversation
6e42792
to
adf5524
Compare
51ae6eb
to
b4437fb
Compare
7312acd
to
1109a5e
Compare
1109a5e
to
28ff78b
Compare
8f56d71
to
0a22e93
Compare
0a22e93
to
25f74fe
Compare
25f74fe
to
8a22461
Compare
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
d2ff0bb
to
608fee3
Compare
if ($json === '') { | ||
return []; | ||
} | ||
return json_decode($json, true, flags: JSON_THROW_ON_ERROR); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that this wasn't clear, we should also handle the JSON exceptions somewhere, so they don't break the whole server and cause a HTTP 500.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think should happen if the value is not parsable, return all task types or return none? I would say none so we do not enable something that should be disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, makes sense. Perhaps, we can also reset the value in the config to a valid json value when this happens?
99c0960
to
7699f88
Compare
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
7699f88
to
7024824
Compare
Summary
Makes taskprocessing task types toggable in AI admin settings: disabled types will not be available and will not show up in e.g. the assistant.
Task types are enabled by default. The values are stored in a new appconfig db record.
Before:
After:
Checklist
Backports requested where applicable (ex: critical bugfixes)not applicable