chore(absence): Add capability #49581
Open
+48
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
approved these changes
Dec 1, 2024
nickvergessen
requested changes
Dec 1, 2024
|
|
||
| class Capabilities implements ICapability { | ||
| public function __construct( | ||
| private IConfig $config, | ||
| private IAvailabilityCoordinator $coordinator, |
There was a problem hiding this comment.
There were 2 errors:
1) OCA\DAV\Tests\unit\CapabilitiesTest::testGetCapabilities
ArgumentCountError: Too few arguments to function OCA\DAV\Capabilities::__construct(), 1 passed in /home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CapabilitiesTest.php on line 22 and exactly 2 expected
/home/runner/actions-runner/_work/server/server/apps/dav/lib/Capabilities.php:13
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CapabilitiesTest.php:22
2) OCA\DAV\Tests\unit\CapabilitiesTest::testGetCapabilitiesWithBulkUpload
ArgumentCountError: Too few arguments to function OCA\DAV\Capabilities::__construct(), 1 passed in /home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CapabilitiesTest.php on line 37 and exactly 2 expected
/home/runner/actions-runner/_work/server/server/apps/dav/lib/Capabilities.php:13
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CapabilitiesTest.php:37
--
There was 1 failure:
1) OCA\DAV\Tests\unit\CalDAV\Reminder\NotificationProviderManagerTest::testRegisterBadProvider
Your test case is not allowed to access the database.
Want a PHP dev to take over?
There was a problem hiding this comment.
Want a PHP dev to take over?
Sorry for the trouble. Should be fine now?!
SystemKeeper
force-pushed
the
fix/noid/add-absence-capability
branch
from
03c6239
to
f365065
Compare
SystemKeeper
requested review from
st3iny,
SebastianKrupinski and
tcitworld
as code owners
SystemKeeper
force-pushed
the
fix/noid/add-absence-capability
branch
from
f365065
to
21190ab
Compare
Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
force-pushed
the
fix/noid/add-absence-capability
branch
from
21190ab
to
303a21f
Compare
SystemKeeper
changed the title
SystemKeeper
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We started using the absence / out-of-office api in talk-ios recently, but there's no capability for us to check if a server supports the absence api (NC 28) and setting a replacement (NC 30).
TODO
Checklist