Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use inline password confirmation in external storage settings #49493

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Nov 26, 2024

Most of the front-end logic is in the library nextcloud-libraries/nextcloud-password-confirmation#881

Fix #49349

@artonge artonge added 3. to review Waiting for reviews feature: external storage php Pull requests that update Php code labels Nov 26, 2024
@artonge artonge added this to the Nextcloud 31 milestone Nov 26, 2024
@artonge artonge self-assigned this Nov 26, 2024
@artonge
Copy link
Contributor Author

artonge commented Nov 26, 2024

/backport to stable30

@artonge
Copy link
Contributor Author

artonge commented Nov 26, 2024

/backport to stable29

@artonge
Copy link
Contributor Author

artonge commented Nov 26, 2024

/backport to stable28

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend changes are neat.

@artonge artonge force-pushed the artonge/feat/pwd_confirmation_allow_set_period branch 8 times, most recently from 8c73da9 to 8687f83 Compare November 28, 2024 09:50
@artonge artonge force-pushed the artonge/feat/pwd_confirmation_allow_set_period branch from 8687f83 to 188b3fd Compare November 28, 2024 10:02
@artonge artonge force-pushed the artonge/feat/pwd_confirmation_allow_set_period branch from 188b3fd to a55db3d Compare November 28, 2024 10:05
@artonge artonge force-pushed the artonge/feat/pwd_confirmation_allow_set_period branch from a55db3d to d6fa210 Compare November 28, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: external storage php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't save global credentials in external storage
4 participants