-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use inline password confirmation in external storage settings #49493
Merged
skjnldsv
merged 6 commits into
master
from
artonge/feat/pwd_confirmation_allow_set_period
Nov 28, 2024
Merged
feat: Use inline password confirmation in external storage settings #49493
skjnldsv
merged 6 commits into
master
from
artonge/feat/pwd_confirmation_allow_set_period
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
3. to review
Waiting for reviews
feature: external storage
php
Pull requests that update Php code
labels
Nov 26, 2024
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
come-nc
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend changes are neat.
artonge
commented
Nov 26, 2024
artonge
force-pushed
the
artonge/feat/pwd_confirmation_allow_set_period
branch
8 times, most recently
from
November 28, 2024 09:50
8c73da9
to
8687f83
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/feat/pwd_confirmation_allow_set_period
branch
from
November 28, 2024 10:02
8687f83
to
188b3fd
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/feat/pwd_confirmation_allow_set_period
branch
from
November 28, 2024 10:05
188b3fd
to
a55db3d
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/feat/pwd_confirmation_allow_set_period
branch
from
November 28, 2024 10:13
a55db3d
to
d6fa210
Compare
skjnldsv
approved these changes
Nov 28, 2024
provokateurin
approved these changes
Nov 28, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the front-end logic is in the library nextcloud-libraries/nextcloud-password-confirmation#881
Fix #49349