fix: Handle copy of folders containing live photos #49293
+282
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
Nov 14, 2024
kesselb
reviewed
Nov 14, 2024
|
getDirectoryListing may return a listing like
Loop:
It would be nice to skip the copy process for a.mov and a.jpg for the second execution if that's possible without making the whole logic much more complex. |
artonge
force-pushed
the
artonge/fix/handle_folders_copy_live_photos
branch
5 times, most recently
from
48eee31
to
edf6450
Compare
artonge
changed the base branch from
master
to
artonge/chore/update_nc_cypress_beta.11
artonge
force-pushed
the
artonge/fix/handle_folders_copy_live_photos
branch
2 times, most recently
from
5de0228
to
c74b1ba
Compare
come-nc
reviewed
Nov 21, 2024
artonge
force-pushed
the
artonge/fix/handle_folders_copy_live_photos
branch
from
c74b1ba
to
892349f
Compare
come-nc
approved these changes
Nov 21, 2024
|
Regression: It's no longer possible to copy a folder in the current folder. ("Testfiles" is an external local storage) master: Screencast.From.2024-11-21.19-25-26.webmthis pr: Screencast.From.2024-11-21.19-26-00.webm |
|
Regression: Copying a folder with live photos is not possible. (Tested on the same external storage and from external storage to primary 3). master: Screencast.From.2024-11-21.19-38-17.webmthis pr: Screencast.From.2024-11-21.19-37-50.webm |
|
Test cases:
|
ArtificialOwl
approved these changes
Nov 25, 2024
artonge
force-pushed
the
artonge/chore/update_nc_cypress_beta.11
branch
5 times, most recently
from
5966751
to
ebda7b4
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/handle_folders_copy_live_photos
branch
from
892349f
to
5e692da
Compare
Base automatically changed from
artonge/chore/update_nc_cypress_beta.11
to
master
November 26, 2024 09:17
We need to recursively look for live photos in the folder, and then handle them as usual. Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/handle_folders_copy_live_photos
branch
from
50b5b5e
to
8e81852
Compare
…a mov file with the same name Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/handle_folders_copy_live_photos
branch
2 times, most recently
from
43ed165
to
5b01166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to recursively look for live photos in the folder, and then handle them as usual.
Fix #49289
Fix #49307