Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #48170

Closed
wants to merge 1 commit into from
Closed

wip #48170

wants to merge 1 commit into from

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Sep 18, 2024

Intermediary, should close.

Signed-off-by: fenn-cs <[email protected]>
@@ -619,4 +619,9 @@
$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value, $oldValue]);
}
}

public function isFederated(): bool {

Check failure

Code scanning / Psalm

InvalidReturnType Error

The declared return type 'bool' for OC\User\User::isFederated is incorrect, got '0'

public function isFederated(): bool {
// Federated users only use LazyUser
return 0;

Check failure

Code scanning / Psalm

InvalidReturnStatement Error

The inferred type '0' does not match the declared return type 'bool' for OC\User\User::isFederated
/**
* Check if the user is federated (from another server)
*
* @return boll

Check failure

Code scanning / Psalm

UndefinedDocblockClass Error

Docblock-defined class, interface or enum named OCP\boll does not exist
@nfebe
Copy link
Contributor Author

nfebe commented Sep 18, 2024

Mission accomplished

@nfebe nfebe closed this Sep 18, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant