Object store move fixes and more #48160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
artonge,
yemkareems and
provokateurin
and removed request for
a team
icewind1991
force-pushed
the
object-store-move-fixes
branch
from
0e8eac6
to
4baf83f
Compare
yemkareems
approved these changes
Sep 18, 2024
provokateurin
approved these changes
Sep 18, 2024
come-nc
approved these changes
Sep 18, 2024
|
It seems to uncover a lot of different problems according to the tests. |
icewind1991
added
2. developing
…FromStorage Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
object-store-move-fixes
branch
from
4baf83f
to
8b06ce1
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
object-store-move-fixes
branch
from
8b06ce1
to
431846b
Compare
icewind1991
force-pushed
the
object-store-move-fixes
branch
from
431846b
to
bdaac72
Compare
|
@icewind1991 |
icewind1991
force-pushed
the
object-store-move-fixes
branch
from
bdaac72
to
0792108
Compare
icewind1991
added
3. to review
|
phpunit is green now |
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
object-store-move-fixes
branch
from
f325c71
to
1ad58d6
Compare
|
Seems like the sharding bug is back on oracle. |
|
from what I can tell |
|
/backport to stable30 |
2 tasks
This was referenced Sep 19, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues in cross-storage moves with object storage found by the tests added in #47986
I'm not sure how much of these issues would occur in the real world or only in the artificial test situations.
Comes with a bonus lower overhead
file_put_contentsimplementation.Fixes #48169