Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate samba files_external test from drone to github #43516

Merged
merged 3 commits into from
Mar 14, 2024
Merged

chore: Migrate samba files_external test from drone to github #43516

merged 3 commits into from
Mar 14, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 10, 2024 •
edited by nickvergessen
Loading

Summary

Migrate the samba files_external test from drone to github.

TODO

Checklist

@susnux susnux force-pushed the chore/migrate-smb-to-github branch 6 times, most recently from d00ff21 to 6b79eea Compare February 10, 2024 23:26
@susnux susnux added 3. to review Waiting for reviews CI labels Feb 10, 2024
@susnux susnux added this to the Nextcloud 29 milestone Feb 10, 2024
@susnux susnux changed the title Chore/migrate smb to GitHub chore: Migrate samba files_external test from drone to github Feb 10, 2024
@susnux susnux requested review from skjnldsv and come-nc February 10, 2024 23:29
@susnux susnux marked this pull request as ready for review February 10, 2024 23:30
This was referenced Feb 10, 2024
Merged
Closed
@nickvergessen
Copy link
Member

Needs to be rebased after #43514 otherwise I can't sign the config

@susnux susnux force-pushed the chore/migrate-smb-to-github branch from a68a9af to 0bee59e Compare February 14, 2024 14:20
@nickvergessen
chore(CI): Sign .drone.yml
3c5db91 
Signed-off-by: Joas Schilling <[email protected]>
@susnux
Copy link
Contributor Author

susnux commented Feb 14, 2024

Needs to be rebased after #43514 otherwise I can't sign the config

@nickvergessen done

@susnux susnux requested a review from come-nc February 14, 2024 14:25
@nickvergessen
Copy link
Member

Signed already

@susnux susnux requested review from a team and ArtificialOwl and removed request for a team February 15, 2024 17:58
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 23, 2024
This was referenced Mar 12, 2024
Merged
Merged
@susnux susnux mentioned this pull request Mar 14, 2024
Merged
4 tasks
@susnux susnux merged commit 392663d into master Mar 14, 2024
163 checks passed
@susnux susnux deleted the chore/migrate-smb-to-github branch March 14, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
2. developing Work in progress CI
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @nickvergessen @skjnldsv @come-nc