Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add translations on the login page #42100

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 7, 2023

Summary

Login form has translations from core app.

script('core') on the login template doesn't load translations because addScript ignores translations for the core app. Translations should be loaded implicitly.

Before Util::addTranslations('core'); was always a part of initTemplateEngine, but it was changed on the mentioned PR.

Screenshots

Before After
image image

Checklist

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 7, 2023

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 7, 2023

/backport to stable28

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 7, 2023

Drone is unrelated, but I have no rights to restart it.

@skjnldsv skjnldsv merged commit cdb6f37 into master Dec 8, 2023
49 of 50 checks passed
@skjnldsv skjnldsv deleted the fix/41881-login-page-translation branch December 8, 2023 09:01
@skjnldsv
Copy link
Member

skjnldsv commented Dec 8, 2023

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants