Reduce the number of container queries #39888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
nickvergessen,
a team,
ArtificialOwl,
blizzz and
nfebe
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
less-container-queries
branch
2 times, most recently
from
d34d475 to
1906e39
Compare
icewind1991
force-pushed
the
less-container-queries
branch
from
1906e39 to
0c0e7d4
Compare
AndyScherzinger
approved these changes
Aug 18, 2023
Altahrim
approved these changes
Aug 18, 2023
|
acceptance failures might be related, will look into it later |
icewind1991
added
2. developing
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
less-container-queries
branch
from
0c0e7d4 to
55fa391
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
less-container-queries
branch
from
55fa391 to
b6c3507
Compare
nickvergessen
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks DI in various places to prevent calling
Server::getin a loop.While the container is fairly fast, doing a lot of queries adds up.