-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(security): Add a bruteforce protection backend base on memcache #39870
Conversation
5f5132f
to
f583a3c
Compare
9bf1975
to
8592c48
Compare
|
||
$data = [ | ||
'allow-listed' => $this->throttler->isIPWhitelisted($ip), | ||
'attempts' => $this->throttler->getAttempts( |
Check notice
Code scanning / Psalm
DeprecatedMethod
$ip, | ||
(string) $input->getArgument('action'), | ||
), | ||
'delay' => $this->throttler->getDelay( |
Check notice
Code scanning / Psalm
DeprecatedMethod
9bae121
to
2a6e4be
Compare
I've created a similar bruteforce stats command recently: #39580 |
2a6e4be
to
0c7bc29
Compare
e33b647
to
90bfa01
Compare
/backport to stable27 |
6816c17
to
3d9b2ad
Compare
@@ -920,6 +925,8 @@ | |||
'cronInfo' => $this->getLastCronInfo(), | |||
'cronErrors' => $this->getCronErrors(), | |||
'isFairUseOfFreePushService' => $this->isFairUseOfFreePushService(), | |||
'isBruteforceThrottled' => $this->throttler->getAttempts($this->request->getRemoteAddress()) !== 0, |
Check notice
Code scanning / Psalm
DeprecatedMethod
Similar to the ratelimit backend Signed-off-by: Joas Schilling <[email protected]>
…oesn't sleep Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
3d9b2ad
to
09cba0d
Compare
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
09cba0d
to
bed3ffb
Compare
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
TODO
Checklist