Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.3.1.1/1.1 - Even though the page is in English, the "lang" attribute is set to the value for the German language, which leads to incorrect screen reader output (1) #41881

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 3 comments · Fixed by #42100
Closed

[BITV] 9.3.1.1/1.1 - Even though the page is in English, the "lang" attribute is set to the value for the German language, which leads to incorrect screen reader output (1) #41881

JuliaKirschenheuter opened this issue Nov 29, 2023 · 3 comments · Fixed by #42100
Assignees
@ShGKme
Labels
3. to review Waiting for reviews accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 29, 2023 •
edited
Loading

output - .

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-92f1119819-v1-n1
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title [BITV] 9.3.1.1/1.1 - Even though the page is in English, the "lang" attribute is set to the value for the German language, which leads to incorrect screen reader output - <html class="ng-csp" data-placeholder-focus="false" lang="de-DE" data-locale="de_DE" translate="no">. (1) [BITV] 9.3.1.1/1.1 - Even though the page is in English, the "lang" attribute is set to the value for the German language, which leads to incorrect screen reader output (1) Nov 29, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Nov 29, 2023

The page is in German. However, the most important part - the Login form is not translated.

The login page only has translations for the "theming" app, but the login form is translated as a part of the "core" app.

image

image

@ShGKme ShGKme self-assigned this Nov 29, 2023
This was referenced Nov 29, 2023
Closed
Closed
@ShGKme ShGKme mentioned this issue Dec 7, 2023
Merged
4 tasks
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Dec 7, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 8, 2023

Waiting for a backport to stable28

@ShGKme ShGKme reopened this Dec 8, 2023
@szaimen szaimen removed the bug label Dec 8, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 8, 2023

Closed now by #42113

@ShGKme ShGKme closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): add translations on the login page nextcloud/server
3 participants
@JuliaKirschenheuter @ShGKme @szaimen