feat(files): add delete, rename and sidebar keyboard shortcut

Signed-off-by: skjnldsv <[email protected]>

apps/files/src/actions/deleteAction.ts

@@ -16,8 +16,10 @@ import { askConfirmation, canDisconnectOnly, canUnshareOnly, deleteNode, display
 
 const queue = new PQueue({ concurrency: 5 })
 
+export const ACTION_DELETE = 'delete'
+
 export const action = new FileAction({
-	id: 'delete',
+	id: ACTION_DELETE,
 	displayName,
 	iconSvgInline: (nodes: Node[]) => {
 		if (canUnshareOnly(nodes)) {
@@ -41,8 +43,13 @@ export const action = new FileAction({
 		try {
 			let confirm = true
 
+			// Trick to detect if the action was called from a keyboard event
+			const callStack = new Error().stack || ''
+			const isCalledFromEventListener = callStack.toLocaleLowerCase().includes('keydown')
+
+			debugger
 			// If trashbin is disabled, we need to ask for confirmation
-			if (!isTrashbinEnabled()) {
+			if (!isTrashbinEnabled() || isCalledFromEventListener) {
 				confirm = await askConfirmation([node], view)
 			}
 

apps/files/src/actions/renameAction.ts

@@ -7,10 +7,10 @@ import { Permission, type Node, FileAction, View } from '@nextcloud/files'
 import { translate as t } from '@nextcloud/l10n'
 import PencilSvg from '@mdi/svg/svg/pencil.svg?raw'
 
-export const ACTION_DETAILS = 'details'
+export const ACTION_RENAME = 'rename'
 
 export const action = new FileAction({
-	id: 'rename',
+	id: ACTION_RENAME,
 	displayName: () => t('files', 'Rename'),
 	iconSvgInline: () => PencilSvg,
 

apps/files/src/actions/sidebarAction.ts

@@ -44,6 +44,11 @@ export const action = new FileAction({
 
 	async exec(node: Node, view: View, dir: string) {
 		try {
+			// If the sidebar is already open for the current file, do nothing
+			if (window.OCA.Files.Sidebar.file === node.path) {
+				logger.debug('Sidebar already open for this file', { node })
+				return null
+			}
 			// Open sidebar and set active tab to sharing by default
 			window.OCA.Files.Sidebar.setActiveTab('sharing')
 

apps/files/src/components/FileEntry/FileEntryActions.vue

@@ -98,6 +98,9 @@ import { useFileListWidth } from '../../composables/useFileListWidth.ts'
 import { useNavigation } from '../../composables/useNavigation'
 import { useRouteParameters } from '../../composables/useRouteParameters.ts'
 import logger from '../../logger.ts'
+import { ACTION_DETAILS } from '../../actions/sidebarAction.ts'
+import { ACTION_RENAME } from '../../actions/renameAction.ts'
+import { ACTION_DELETE } from '../../actions/deleteAction.ts'
 
 export default defineComponent({
 	name: 'FileEntryActions',
@@ -354,6 +357,28 @@ export default defineComponent({
 				event.stopPropagation()
 				this.openedMenu = true
 			}
+
+			// d opens the sidebar
+			if (event.key === 'd') {
+				event.preventDefault()
+				event.stopPropagation()
+				this.onActionClick(this.enabledFileActions.find(action => action.id === ACTION_DETAILS)!)
+			}
+
+			// F2 renames the file
+			if (event.key === 'F2') {
+				event.preventDefault()
+				event.stopPropagation()
+				this.onActionClick(this.enabledFileActions.find(action => action.id === ACTION_RENAME)!)
+			}
+
+			// Delete key deletes the file with confirmation
+			if (event.key === 'Delete') {
+				event.preventDefault()
+				event.stopPropagation()
+				this.onActionClick(this.enabledFileActions.find(action => action.id === ACTION_DELETE)!)
+			}
+
 		},
 	},
 })