fixup! feat: Use inline password confirmation in external storage set…

…tings

lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php

@@ -83,23 +83,37 @@ public function beforeController(Controller $controller, string $methodName) {
 				}
 			}
 
+			$backendClassName = $user->getBackendClassName();
+
 			try {
 				$sessionId = $this->session->getId();
 				$token = $this->tokenProvider->getToken($sessionId);
 			} catch (SessionNotAvailableException|InvalidTokenException|WipeTokenException|ExpiredTokenException) {
 				// States we do not deal with here.
 				return;
 			}
+
 			$scope = $token->getScopeAsArray();
 			if (isset($scope['password-unconfirmable']) && $scope['password-unconfirmable'] === true) {
 				// Users logging in from SSO backends cannot confirm their password by design
 				return;
 			}
 
-			$lastConfirm = (int) $this->session->get('last-password-confirm');
-			// TODO: confirm excludedUserBackEnds can go away and remove it
-			if (!isset($this->excludedUserBackEnds[$backendClassName]) && $lastConfirm < ($this->timeFactory->getTime() - (30 * 60 + 15))) { // allow 15 seconds delay
-				throw new NotConfirmedException();
+			if ($this->isPasswordConfirmationStrict($reflectionMethod)) {
+				$authHeader = $this->request->getHeader('Authorization');
+				[, $password] = explode(':', base64_decode(substr($authHeader, 6)), 2);
+				$loginResult = $this->userManager->checkPassword($user->getUid(), $password);
+				if ($loginResult === false) {
+					throw new NotConfirmedException();
+				}
+
+				$this->session->set('last-password-confirm', $this->timeFactory->getTime());
+			} else {
+				$lastConfirm = (int) $this->session->get('last-password-confirm');
+				// TODO: confirm excludedUserBackEnds can go away and remove it
+				if (!isset($this->excludedUserBackEnds[$backendClassName]) && $lastConfirm < ($this->timeFactory->getTime() - (30 * 60 + 15))) { // allow 15 seconds delay
+					throw new NotConfirmedException();
+				}
 			}
 		}
 	}