Skip to content

Commit

Permalink
Merge pull request #42077 from nextcloud/enh/a11y/app-nav-labels
Browse files Browse the repository at this point in the history
enh(a11y): Add navigation labels
  • Loading branch information
nickvergessen authored Dec 7, 2023
2 parents 4f8c998 + cad0f58 commit c41cbcf
Show file tree
Hide file tree
Showing 11 changed files with 17 additions and 15 deletions.
3 changes: 2 additions & 1 deletion apps/files/src/views/Navigation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
-
-->
<template>
<NcAppNavigation data-cy-files-navigation>
<NcAppNavigation data-cy-files-navigation
:aria-label="t('files', 'Files')">
<template #list>
<NcAppNavigationItem v-for="view in parentViews"
:key="view.id"
Expand Down
3 changes: 2 additions & 1 deletion apps/settings/src/views/Apps.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
<NcContent app-name="settings"
:class="{ 'with-app-sidebar': app}">
<!-- Categories & filters -->
<NcAppNavigation :class="{ 'icon-loading': loading }">
<NcAppNavigation :class="{ 'icon-loading': loading }"
:aria-label="t('settings', 'Apps')">
<template #list>
<NcAppNavigationItem id="app-category-your-apps"
:to="{ name: 'apps' }"
Expand Down
2 changes: 1 addition & 1 deletion apps/settings/src/views/Users.vue
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<template>
<Fragment>
<NcContent app-name="settings">
<NcAppNavigation>
<NcAppNavigation :aria-label="t('settings', 'User management')">
<NcAppNavigationNew button-id="new-user-button"
:text="t('settings','New user')"
@click="showNewUserMenu"
Expand Down
4 changes: 2 additions & 2 deletions dist/files-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-main.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/settings-apps-view-7418.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-apps-view-7418.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/settings-users-8351.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-users-8351.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/settings-vue-settings-apps-users-management.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-vue-settings-apps-users-management.js.map

Large diffs are not rendered by default.

0 comments on commit c41cbcf

Please sign in to comment.