Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
Signed-off-by: fenn-cs <[email protected]>
  • Loading branch information
nfebe committed Sep 18, 2024
1 parent 7a4e088 commit b40e85c
Show file tree
Hide file tree
Showing 9 changed files with 81 additions and 3 deletions.
6 changes: 6 additions & 0 deletions apps/dav/lib/Connector/Sabre/FilesPlugin.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ class FilesPlugin extends ServerPlugin {
public const MOUNT_TYPE_PROPERTYNAME = '{http://nextcloud.org/ns}mount-type';
public const MOUNT_ROOT_PROPERTYNAME = '{http://nextcloud.org/ns}is-mount-root';
public const IS_ENCRYPTED_PROPERTYNAME = '{http://nextcloud.org/ns}is-encrypted';
public const IS_FEDERATED_PROPERTYNAME = '{http://nextcloud.org/ns}is-federated';
public const METADATA_ETAG_PROPERTYNAME = '{http://nextcloud.org/ns}metadata_etag';
public const UPLOAD_TIME_PROPERTYNAME = '{http://nextcloud.org/ns}upload_time';
public const CREATION_TIME_PROPERTYNAME = '{http://nextcloud.org/ns}creation_time';
Expand Down Expand Up @@ -149,6 +150,7 @@ public function initialize(Server $server) {
$server->protectedProperties[] = self::HAS_PREVIEW_PROPERTYNAME;
$server->protectedProperties[] = self::MOUNT_TYPE_PROPERTYNAME;
$server->protectedProperties[] = self::IS_ENCRYPTED_PROPERTYNAME;
$server->protectedProperties[] = self::IS_FEDERATED_PROPERTYNAME;
$server->protectedProperties[] = self::SHARE_NOTE;

// normally these cannot be changed (RFC4918), but we want them modifiable through PROPPATCH
Expand Down Expand Up @@ -413,6 +415,10 @@ public function handleGetProperties(PropFind $propFind, \Sabre\DAV\INode $node)
$propFind->handle(self::DISPLAYNAME_PROPERTYNAME, function () use ($node) {
return $node->getName();
});

$propFind->handle(self::IS_FEDERATED_PROPERTYNAME, function () use ($node) {

Check notice

Code scanning / Psalm

MissingClosureReturnType Note

Closure does not have a return type, expecting mixed
return $node->getOwner()->isFederated();
});
}

if ($node instanceof \OCA\DAV\Connector\Sabre\File) {
Expand Down
2 changes: 2 additions & 0 deletions apps/files/src/components/VirtualList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,12 @@ export default Vue.extend({
}
const items = this.dataSources.slice(this.startIndex, this.startIndex + this.shownItems) as Node[]
console.log("Items list", items)
const oldItems = items.filter(item => Object.values(this.$_recycledPool).includes(item[this.dataKey]))
const oldItemsKeys = oldItems.map(item => item[this.dataKey] as string)
const unusedKeys = Object.keys(this.$_recycledPool).filter(key => !oldItemsKeys.includes(this.$_recycledPool[key]))
console.log("Unused keys", unusedKeys)
return items.map(item => {
const index = Object.values(this.$_recycledPool).indexOf(item[this.dataKey])
Expand Down
20 changes: 19 additions & 1 deletion apps/files_sharing/src/actions/sharingStatusAction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,22 @@ import { generateAvatarSvg } from '../utils/AccountIcon.ts'

import './sharingStatusAction.scss'

<<<<<<< Updated upstream
=======
const isDarkMode = window?.matchMedia?.('(prefers-color-scheme: dark)')?.matches === true
|| document.querySelector('[data-themes*=dark]') !== null

const generateAvatarSvg = (userId: string, isGuest = false) => {
console.debug("USER ID, is Guest", userId, isGuest)
const url = isDarkMode ? '/avatar/{userId}/32/dark' : '/avatar/{userId}/32'
const avatarUrl = generateUrl(isGuest ? url : url + '?guestFallback=true', { userId })
return `<svg width="32" height="32" viewBox="0 0 32 32"
xmlns="http://www.w3.org/2000/svg" class="sharing-status__avatar">
<image href="${avatarUrl}" height="32" width="32" />
</svg>`
}

>>>>>>> Stashed changes
const isExternal = (node: Node) => {
return node.attributes.remote_id !== undefined
}
Expand Down Expand Up @@ -100,7 +116,9 @@ export const action = new FileAction({

const ownerId = node?.attributes?.['owner-id']
if (ownerId && (ownerId !== getCurrentUser()?.uid || isExternal(node))) {
return generateAvatarSvg(ownerId, isExternal(node))
console.debug("IS EXTERNAL", isExternal(node))
console.debug("EXTENAL NODE", node)
return generateAvatarSvg(ownerId, true)
}

return AccountPlusSvg
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/src/services/SharingService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const ocsEntryToNode = async function(ocsEntry: any): Promise<Folder | File | nu

let mtime = ocsEntry.item_mtime ? new Date((ocsEntry.item_mtime) * 1000) : undefined
// Prefer share time if more recent than item mtime
if (ocsEntry?.stime > (ocsEntry?.item_mtime || 0)) {
if (ocsEntry?.stime > (ocsEntry?.item_mtime || 0)) {ocsEntryToNode
mtime = new Date((ocsEntry.stime) * 1000)
}

Expand Down
13 changes: 13 additions & 0 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
Original file line number Diff line number Diff line change
Expand Up @@ -880,8 +880,21 @@ export default {
}
await this.getNode()
console.log("Newly fetched", this.node)
emit('files:node:updated', this.node)
<<<<<<< Updated upstream
=======
if (this.$refs.externalLinkActions?.length > 0) {
await Promise.allSettled(this.$rethis.nodefs.externalLinkActions.map((action) => {
if (typeof action.$children.at(0)?.onSave !== 'function') {
return Promise.resolve()
}
return action.$children.at(0)?.onSave?.()
}))
}
>>>>>>> Stashed changes
this.$emit('close-sharing-details')
},
/**
Expand Down
14 changes: 13 additions & 1 deletion core/src/files/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ import escapeHTML from 'escape-html'
Client.PROPERTY_SIZE = '{' + Client.NS_OWNCLOUD + '}size'
Client.PROPERTY_GETCONTENTLENGTH = '{' + Client.NS_DAV + '}getcontentlength'
Client.PROPERTY_ISENCRYPTED = '{' + Client.NS_DAV + '}is-encrypted'
Client.PROPERTY_ISFEDERATED = '{' + Client.NS_DAV + '}is-federated'
Client.PROPERTY_SHARE_PERMISSIONS = '{' + Client.NS_OCS + '}share-permissions'
Client.PROPERTY_SHARE_ATTRIBUTES = '{' + Client.NS_NEXTCLOUD + '}share-attributes'
Client.PROPERTY_QUOTA_AVAILABLE_BYTES = '{' + Client.NS_DAV + '}quota-available-bytes'
Expand Down Expand Up @@ -157,6 +158,10 @@ import escapeHTML from 'escape-html'
* Encryption state
*/
[Client.NS_NEXTCLOUD, 'is-encrypted'],
/**
* Federation state
*/
[Client.NS_NEXTCLOUD, 'is-federated'],
/**
* Share permissions
*/
Expand Down Expand Up @@ -303,7 +308,7 @@ import escapeHTML from 'escape-html'
*
* @returns {Array.<FileInfo>} array of file info
*/
_parseFileInfo: function(response) {
_parseFileInfo: function(response) {Encrypted
let path = decodeURIComponent(response.href)
if (path.substr(0, this._root.length) === this._root) {
path = path.substr(this._root.length)
Expand Down Expand Up @@ -355,6 +360,13 @@ import escapeHTML from 'escape-html'
data.isEncrypted = false
}

const isFederatedProp = props['{' + Client.NS_NEXTCLOUD + '}is-federated']
if (!_.isUndefined(isFederatedProp)) {
data.isFederated = isFederatedProp === '1'
} else {
data.isFederated = false
}

const isFavouritedProp = props['{' + Client.NS_OWNCLOUD + '}favorite']
if (!_.isUndefined(isFavouritedProp)) {
data.isFavourited = isFavouritedProp === '1'
Expand Down
14 changes: 14 additions & 0 deletions lib/private/User/LazyUser.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ private function getUser(): IUser {
$this->user = $this->userManager->get($this->uid);
}
}

if($this->user === null) {
throw new \Exception('User not found');
}

/** @var IUser */
$user = $this->user;
return $user;
Expand Down Expand Up @@ -167,4 +172,13 @@ public function getManagerUids(): array {
public function setManagerUids(array $uids): void {
$this->getUser()->setManagerUids($uids);
}

public function isFederated(): bool {
try {
$this->getUser();
return true;
} catch (\Exception $e) {
return false;
}
}
}
5 changes: 5 additions & 0 deletions lib/private/User/User.php
Original file line number Diff line number Diff line change
Expand Up @@ -618,4 +618,9 @@ public function triggerChange($feature, $value = null, $oldValue = null) {
$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value, $oldValue]);
}
}

public function isFederated(): bool {
// Federated users only use LazyUser
return false;
}
}
8 changes: 8 additions & 0 deletions lib/public/IUser.php
Original file line number Diff line number Diff line change
Expand Up @@ -287,4 +287,12 @@ public function getManagerUids(): array;
* @since 27.0.0
*/
public function setManagerUids(array $uids): void;

/**
* Check if the user is federated (from another server)
*
* @return boll

Check failure on line 294 in lib/public/IUser.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

UndefinedDocblockClass

lib/public/IUser.php:294:13: UndefinedDocblockClass: Docblock-defined class, interface or enum named OCP\boll does not exist (see https://psalm.dev/200)

Check failure on line 294 in lib/public/IUser.php

View workflow job for this annotation

GitHub Actions / static-code-analysis-ocp

UndefinedDocblockClass

lib/public/IUser.php:294:13: UndefinedDocblockClass: Docblock-defined class, interface or enum named OCP\boll does not exist (see https://psalm.dev/200)

Check failure

Code scanning / Psalm

UndefinedDocblockClass Error

Docblock-defined class, interface or enum named OCP\boll does not exist
* @since 28.0.11
*/
public function isFederated(): bool;
}

0 comments on commit b40e85c

Please sign in to comment.