Fix path when app has wrong permission

Replace slow array function used in loop: https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop Signed-off-by: Daniel Kesselberg <[email protected]>
nextcloud · Aug 30, 2018 · a6bb19f · a6bb19f
1 parent ce87537
commit a6bb19f
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/settings/Controller/CheckSetupController.php b/settings/Controller/CheckSetupController.php
@@ -544,18 +544,17 @@ protected function hasOpcacheLoaded(): bool {
 	 */
 	protected function getAppDirsWithDifferentOwner(): array {
 		$currentUser = posix_getpwuid(posix_getuid());
-		$appDirsWithDifferentOwner = [];
+		$appDirsWithDifferentOwner = [[]];
 
 		foreach (OC::$APPSROOTS as $appRoot) {
 			if ($appRoot['writable'] === true) {
-				$appDirsWithDifferentOwner = array_merge(
-					$appDirsWithDifferentOwner,
-					$this->getAppDirsWithDifferentOwnerForAppRoot($currentUser, $appRoot)
-				);
+				$appDirsWithDifferentOwner[] = $this->getAppDirsWithDifferentOwnerForAppRoot($currentUser, $appRoot);
 			}
 		}
 
+		$appDirsWithDifferentOwner = array_merge(...$appDirsWithDifferentOwner);
 		sort($appDirsWithDifferentOwner);
+
 		return $appDirsWithDifferentOwner;
 	}
 
@@ -576,7 +575,7 @@ private function getAppDirsWithDifferentOwnerForAppRoot(array $currentUser, arra
 				$absAppPath = $appsPath . DIRECTORY_SEPARATOR . $fileInfo->getFilename();
 				$appDirUser = posix_getpwuid(fileowner($absAppPath));
 				if ($appDirUser !== $currentUser) {
-					$appDirsWithDifferentOwner[] = $absAppPath . DIRECTORY_SEPARATOR . $fileInfo->getFilename();
+					$appDirsWithDifferentOwner[] = $absAppPath;
 				}
 			}
 		}