fixup! feat(files): add delete, rename and sidebar keyboard shortcut

Signed-off-by: skjnldsv <[email protected]>

apps/files/src/actions/deleteAction.ts

@@ -44,10 +44,11 @@ export const action = new FileAction({
 			let confirm = true
 
 			// Trick to detect if the action was called from a keyboard event
+			// we need to make sure the method calling have its named containing 'keydown'
+			// here we use `onKeydown` method from the FileEntryActions component
 			const callStack = new Error().stack || ''
 			const isCalledFromEventListener = callStack.toLocaleLowerCase().includes('keydown')
 
-			debugger
 			// If trashbin is disabled, we need to ask for confirmation
 			if (!isTrashbinEnabled() || isCalledFromEventListener) {
 				confirm = await askConfirmation([node], view)

apps/files/src/actions/favoriteAction.ts

@@ -23,6 +23,8 @@ const shouldFavorite = (nodes: Node[]): boolean => {
 	return nodes.some(node => node.attributes.favorite !== 1)
 }
 
+export const ACTION_FAVORITE = 'favorite'
+
 export const favoriteNode = async (node: Node, view: View, willFavorite: boolean): Promise<boolean> => {
 	try {
 		// TODO: migrate to webdav tags plugin
@@ -59,7 +61,7 @@ export const favoriteNode = async (node: Node, view: View, willFavorite: boolean
 }
 
 export const action = new FileAction({
-	id: 'favorite',
+	id: ACTION_FAVORITE,
 	displayName(nodes: Node[]) {
 		return shouldFavorite(nodes)
 			? t('files', 'Add to favorites')

apps/files/src/components/FileEntry/FileEntryActions.vue

@@ -101,6 +101,7 @@ import logger from '../../logger.ts'
 import { ACTION_DETAILS } from '../../actions/sidebarAction.ts'
 import { ACTION_RENAME } from '../../actions/renameAction.ts'
 import { ACTION_DELETE } from '../../actions/deleteAction.ts'
+import { ACTION_FAVORITE } from '../../actions/favoriteAction.ts'
 
 export default defineComponent({
 	name: 'FileEntryActions',
@@ -379,6 +380,13 @@ export default defineComponent({
 				this.onActionClick(this.enabledFileActions.find(action => action.id === ACTION_DELETE)!)
 			}
 
+			// s toggle favorite
+			if (event.key === 's') {
+				event.preventDefault()
+				event.stopPropagation()
+				this.onActionClick(this.enabledFileActions.find(action => action.id === ACTION_FAVORITE)!)
+			}
+
 		},
 	},
 })