ci: Attempt to make cypress tests more stable with a unified wait for close #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… close Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
|
/backport to stable30 |
elzody
approved these changes
Nov 29, 2024
2 tasks
|
/backport to stable29 |
|
/backport to stable28 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fix #4284
It seems close sometimes takes a bit longer until the viewer frame is actually removed (especially on CI). Move the logic to a cypress command.