Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix: remove deprecated title parameter #4272

Merged
merged 2 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/helpers/url.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const getWopiSrc = (fileId) => {
return wopiurl
}

const getWopiUrl = ({ fileId, title, readOnly, closeButton, revisionHistory, target = undefined }) => {
const getWopiUrl = ({ fileId, readOnly, closeButton, revisionHistory, target = undefined }) => {
// Only set the revision history parameter if the versions app is enabled
revisionHistory = revisionHistory && window?.oc_appswebroots?.files_versions

Expand All @@ -38,7 +38,6 @@ const getWopiUrl = ({ fileId, title, readOnly, closeButton, revisionHistory, tar
// https://<loolwsd-server>:9980/hosting/discovery
return Config.get('urlsrc')
+ 'WOPISrc=' + encodeURIComponent(getWopiSrc(fileId))
+ '&title=' + encodeURIComponent(title)
+ '&lang=' + languageToBCP47()
+ (closeButton ? '&closebutton=1' : '')
+ (revisionHistory ? '&revisionhistory=1' : '')
Expand Down
1 change: 0 additions & 1 deletion src/view/Office.vue
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,6 @@ export default {
// Generate form and submit to the iframe
const action = getWopiUrl({
fileId: fileid + '_' + loadState('richdocuments', 'instanceId', 'instanceid') + (version > 0 ? '_' + version : ''),
title: this.filename,
readOnly: forceReadOnly || version > 0,
revisionHistory: !this.isPublic,
closeButton: !Config.get('hideCloseButton') && !this.isEmbedded,
Expand Down
Loading