Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add proper feature policy #3237

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix: Add proper feature policy #3237

merged 2 commits into from
Oct 23, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 19, 2023 •
edited
Loading

Fixes #3236

Includes some refactoring to avoid duplicating code to generate all relevant domains

  • Unit tests need adjustments

@juliusknorr juliusknorr added bug Something isn't working 2. developing Work in progress regression labels Oct 20, 2023
@juliusknorr juliusknorr force-pushed the bugfix/3236 branch 2 times, most recently from d503e69 to 619b6da Compare October 20, 2023 12:57
@juliusknorr juliusknorr added 3. to review Ready to be reviewed and removed 2. developing Work in progress labels Oct 23, 2023
@juliusknorr
Copy link
Member Author

/backport to stable27

mejo-
mejo- approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible to me.

@juliusknorr juliusknorr merged commit fd94a58 into main Oct 23, 2023
56 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/3236 branch October 23, 2023 21:25
@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr juliusknorr mentioned this pull request Nov 2, 2023
Merged
@blizzz blizzz mentioned this pull request May 16, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NC 27 regression: Fullscreen fails in Chrome due to missing "Feature-Policy: fullscreen" header
2 participants
@juliusknorr @mejo-