Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore selection #2299

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Restore selection #2299

merged 2 commits into from
Nov 6, 2024

Conversation

quthla
Copy link
Contributor

@quthla quthla commented Jul 22, 2024

This PR ensures that selection position is preserved over orientation changes

@quthla quthla force-pushed the restore-selection branch from 068586e to 2ee0e3a Compare July 23, 2024 11:29
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

quthla and others added 2 commits November 6, 2024 08:10
@alperozturk96 alperozturk96 merged commit 121be3d into nextcloud:main Nov 6, 2024
12 checks passed
@quthla quthla deleted the restore-selection branch November 6, 2024 08:45
@quthla
Copy link
Contributor Author

quthla commented Nov 6, 2024

There is 1 little issue with this though. When setting selection, it'll scroll automatically to that position but ideally it would set selection and keep the previous scroll position. Do you know how that can be done @alperozturk96 @tobiasKaminsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants