Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Check generated assets are up-to-date #2684

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

provokateurin
Copy link
Member

Closes #1430

@provokateurin provokateurin marked this pull request as ready for review November 28, 2024 10:43
@provokateurin provokateurin marked this pull request as draft November 28, 2024 10:43
@provokateurin provokateurin force-pushed the ci/generate-assets branch 3 times, most recently from 835d075 to 4bc2ad4 Compare November 28, 2024 12:49
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.90%. Comparing base (332e05a) to head (86c6cec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2684   +/-   ##
=======================================
  Coverage   28.90%   28.90%           
=======================================
  Files         372      372           
  Lines      136624   136624           
=======================================
  Hits        39492    39492           
  Misses      97132    97132           
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 332e05a
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø)
dynamite_end_to_end_test 61.69% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
interceptor_http_client 97.18% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from 332e05a
neon_framework 61.44% <ø> (ø)
neon_http_client 94.32% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 332e05a
neon_storage 94.66% <ø> (ø)
neon_talk 99.45% <ø> (ø) Carriedforward from 332e05a
nextcloud 24.33% <ø> (ø)
notifications_app 97.43% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø)
talk_app 99.01% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@provokateurin
Copy link
Member Author

I fear this idea is not possible right now, as different versions are used and even the precompiled SVGs are different (although I don't understand why).
With a nix flake it should be possible to achieve this though, as then everything should be the exact same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CI to check generated assets are up-to-date
1 participant