Update Travis config for new Nextcloud versions (+ compatibility)

[LEDfan]

New release => new tests 😃

Currently Travis is failing because of some deprecated features used in NC 13:

The command "vendor/bin/php-cs-fixer fix --dry-run --using-cache=no" exited with 0.
2.27s$ rm -r build/ && rm -r vendor/ && ../../occ app:check-code ojsxc
Analysing /home/travis/build/nextcloud/nextcloud/apps/ojsxc/appinfo/app.php
 2 errors
    line    5: OCP\App - Static method of deprecated class must not be called
    line    5: OCP\App::registerPersonal - Method of deprecated class must not be called
Analysing /home/travis/build/nextcloud/nextcloud/apps/ojsxc/lib/Controller/SettingsController.php
 2 errors
    line  269: OCP\User - Static method of deprecated class must not be called
    line  269: OCP\User::isLoggedIn - Method of deprecated class must not be called
Analysing /home/travis/build/nextcloud/nextcloud/apps/ojsxc/settings/personal.php
 2 errors
    line    7: OCP\User - Static method of deprecated class must not be called
    line    7: OCP\User::checkLoggedIn - Method of deprecated class must not be called
App is not compliant

• The first error can be solved by simple removing the line, but this will only work starting from NC 12 (tested in VM).
• The second error is a simple replacement.
• According to https://github.com/nextcloud/jsxc.nextcloud/blob/master/settings/personal.php#L4 the third error can be solved by removing the whole file but this is only NC 13 compatible.

@sualko what do you think would be the best solution:

• ignore the deprecation warnings (it are warnings after all)
• fix the errors and only release new versions of the app for NC 13.
  The Limit chatting to users in your group and allow to exclude certain groups #57 will only work with NC 13 (because of new API) but is made compatible with older versions.

[LEDfan]

Some more deprecated/compatibility stuff which could be solved:

• jsxc.nextcloud/appinfo/application.php

  Line 278 in 4b6daef

  if ($version[0] === 8 && $version[1] === 0){

• jsxc.nextcloud/appinfo/application.php

  Line 281 in 4b6daef

  $memcache = $cache->create('ojsxc');

• jsxc.nextcloud/lib/Controller/SettingsController.php

  Line 332 in 32bd542

  $version = \OCP\Util::getVersion();

• jsxc.nextcloud/lib/Settings/Section.php

  Line 66 in 4e1922e

  $version = \OCP\Util::getVersion();

• jsxc.nextcloud/lib/Settings/Section.php

  Line 66 in 4e1922e

  $version = \OCP\Util::getVersion();

[sualko]

Mh, I only get and see on Travis the last two errors, but anyway I don't want to release different versions for different nc versions, because then the version would not align with the jsxc release.

I think it's ok if we ignore them and the other stuff should be updated in a new pr. Do you have an idea how we still could satisfy travis?

[codecov]

Codecov Report

Merging #86 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
+ Coverage     81.15%   81.17%   +0.02%     
+ Complexity      275      274       -1     
============================================
  Files            29       29              
  Lines           939      951      +12     
============================================
+ Hits            762      772      +10     
- Misses          177      179       +2

Impacted Files	Coverage Δ	Complexity Δ
lib/rosterpush.php	100% <ø> (ø)	11 <0> (ø)	⬇️
lib/newcontentcontainer.php	100% <ø> (ø)	3 <0> (ø)	⬇️
lib/Controller/HttpBindController.php	100% <100%> (ø)	25 <0> (-1)	⬇️
lib/Controller/SettingsController.php	57.8% <0%> (-0.1%)	59% <0%> (ø)
lib/db/iqroster.php	100% <0%> (ø)	2% <0%> (ø)	⬇️
lib/Controller/ManagedServerController.php	100% <0%> (ø)	15% <0%> (ø)	⬇️
lib/db/iqrosterpush.php	100% <0%> (ø)	3% <0%> (ø)	⬇️
lib/TimeLimitedToken.php	100% <0%> (ø)	6% <0%> (ø)	⬇️
lib/DataRetriever.php	0% <0%> (ø)	6% <0%> (ø)	⬇️
lib/Controller/ExternalApiController.php	97.5% <0%> (+0.09%)	29% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ac678...a7414fc. Read the comment docs.

[LEDfan]

That's fine for me. I added || true to the command on Travis so the builds should pass again. Currently the PHP 7.2 build is failing but this should be fixed by #88

[sualko]

Do you have an idea how to fix travis? I tried to remove the composer.lock file in 349f2b4, but this just gave some other errors.

[LEDfan]

Let's see if this works 🙈 ....

[LEDfan]

Builds are finally working!

[sualko]

🎉 great work