-
-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for in-app browser log in #3251
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
facc11a
WIP
mpivchev eb56c26
WIP
mpivchev 027f9d9
WIP
mpivchev 8319a49
WIP
mpivchev 550813f
WIP
mpivchev 02362e3
WIP
mpivchev d4cf9eb
Merge branch 'develop' of https://github.com/nextcloud/ios into fix-v2
mpivchev 3a4e8f9
Finish
mpivchev 4bee385
WIP
mpivchev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// | ||
// UIButton+Extension.swift | ||
// Nextcloud | ||
// | ||
// Created by Milen Pivchev on 17.12.24. | ||
// Copyright © 2024 Marino Faggiana. All rights reserved. | ||
// | ||
Comment on lines
+1
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should have been the usual license header instead, right? 😁 |
||
|
||
extension UIButton { | ||
func hideButtonAndShowSpinner(tint: UIColor = .white) { | ||
self.isHidden = true | ||
|
||
let spinnerTag = Int(bitPattern: Unmanaged.passUnretained(self).toOpaque()) | ||
if self.superview?.subviews.first(where: { view -> Bool in | ||
return view.isKind(of: UIActivityIndicatorView.self) && view.tag == spinnerTag | ||
}) != nil { | ||
return | ||
} | ||
|
||
let spinner = UIActivityIndicatorView(style: .medium) | ||
spinner.tag = spinnerTag | ||
spinner.color = tint | ||
spinner.startAnimating() | ||
spinner.center = self.center | ||
self.superview?.addSubview(spinner) | ||
spinner.translatesAutoresizingMaskIntoConstraints = false | ||
spinner.centerXAnchor.constraint(equalTo: self.centerXAnchor).isActive = true | ||
spinner.centerYAnchor.constraint(equalTo: self.centerYAnchor).isActive = true | ||
} | ||
|
||
func hideSpinnerAndShowButton() { | ||
let spinnerTag = Int(bitPattern: Unmanaged.passUnretained(self).toOpaque()) | ||
let spinner = self.superview?.subviews.first(where: { view -> Bool in | ||
return view.isKind(of: UIActivityIndicatorView.self) && view.tag == spinnerTag | ||
}) | ||
|
||
spinner?.removeFromSuperview() | ||
self.isHidden = false | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marinofaggiana This is needed for a patch, will revert later