Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename validator #2984

Merged
merged 24 commits into from
Aug 21, 2024
Merged

Filename validator #2984

merged 24 commits into from
Aug 21, 2024

Conversation

mpivchev
Copy link
Collaborator

@mpivchev mpivchev commented Jul 19, 2024

We need to cover the following use-cases for this feature

  • [Create a New Document] Tap the plus button on the home screen, select "New Document," and enter a file name for the new document.
  • [Rename a File] Tap the three dots icon at the end of any file in the list, and select "Rename."
  • [Rename a File From File Details] Go to "File Details". From the top right, tap the three dots icon, select "Rename," and test it.
  • [Create a New Folder] Tap the plus button on the home screen, select "New Folder," and enter a name for the new folder.
  • [Move or Copy file to Any Folder] Tap the three dots icon at the end of any file in the list, and select "Move" or "Copy." Attempt to move or copy to both an invalid and a valid folder path.
  • [Share a File From Other Any App] From any other app, try to share a file with the Nextcloud Files app. If the shared file contains invalid characters or reserved name, user must receive feedback, and the operation should not be allowed.
  • [Upload Contents From Other Apps] Tap the plus button on the home screen, select "Upload Contents from Other Apps." If the contents include a path, the user must receive feedback, and the operation should not be allowed.
  • [Create a New File From Other File Manager Apps] User can create forbidden file names from native files app such as Google Files.
  • [Create a New Template] User may have a template for creating office files such as new presentation and new text document etc Not needed for iOS

Edit:

  • Add checks when scanning files

mpivchev added 8 commits July 17, 2024 18:31
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
…ame-validator

Signed-off-by: Milen Pivchev <[email protected]>

# Conflicts:
#	Nextcloud.xcodeproj/project.pbxproj
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
…ame-validator

Signed-off-by: Milen Pivchev <[email protected]>

# Conflicts:
#	File Provider Extension/FileProviderExtension+Actions.swift
#	Nextcloud.xcodeproj/project.pbxproj
#	iOSClient/AppDelegate.swift
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev mpivchev force-pushed the filename-validator branch from d6a459c to 657fba6 Compare August 1, 2024 14:54
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev mpivchev marked this pull request as ready for review August 1, 2024 14:55
@mpivchev mpivchev requested a review from marinofaggiana August 1, 2024 14:55
…ame-validator

Signed-off-by: Milen Pivchev <[email protected]>

# Conflicts:
#	Nextcloud.xcodeproj/project.pbxproj
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
…ame-validator

Signed-off-by: Milen Pivchev <[email protected]>

# Conflicts:
#	Nextcloud.xcodeproj/project.pbxproj
Copy link
Member

@marinofaggiana marinofaggiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload photo or video - Rename file
Simulator Screenshot - iPhone 14 - 2024-08-19 at 14 29 37

@marinofaggiana
Copy link
Member

marinofaggiana commented Aug 19, 2024

Share extension "..." don't works ? pls check

Simulator Screenshot - iPhone 14 - 2024-08-19 at 14 31 11

@mpivchev mpivchev changed the base branch from develop to session_develop August 20, 2024 13:31
@mpivchev mpivchev changed the base branch from session_develop to develop August 20, 2024 13:31
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
@marinofaggiana marinofaggiana self-requested a review August 21, 2024 08:44
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev mpivchev merged commit bef64ee into develop Aug 21, 2024
4 checks passed
@marinofaggiana marinofaggiana deleted the filename-validator branch August 23, 2024 08:24
@marinofaggiana marinofaggiana restored the filename-validator branch August 23, 2024 08:25
@mpivchev mpivchev deleted the filename-validator branch August 28, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants