Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp manageaccount #2951

Merged
merged 59 commits into from
Jun 21, 2024
Merged

Revamp manageaccount #2951

merged 59 commits into from
Jun 21, 2024

Conversation

marinofaggiana
Copy link
Member

@marinofaggiana marinofaggiana commented Jun 20, 2024

  • Removed the account in the More view

Simulator Screenshot - iPhone 15 Pro Max - 2024-06-20 at 12 11 46

  • Added the Account Settings in the account menu left available on Files tab

Simulator Screenshot - iPhone 15 Pro Max - 2024-06-20 at 12 11 55

  • A new view

Simulator Screenshot - iPhone 15 Pro Max - 2024-06-20 at 12 12 04

Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
@mpivchev
Copy link
Collaborator

Looks good!

image

  • Can you replace the email icon with one of these?

image

  • Can you remove the space between the Alias and the ":" ?

@mpivchev
Copy link
Collaborator

Simulator.Screen.Recording.-.iPhone.15.-.2024-06-20.at.13.23.24.mp4
  • If you swipe the carousel slowly it jumps around
  • There is an empty space cutoff on the edges
  • Can you add some animation when the height changes?

@mpivchev
Copy link
Collaborator

image

You can replace this icon with the gear icon for settings

@mpivchev
Copy link
Collaborator

mpivchev commented Jun 20, 2024

image

It's hard to know you can swipe left and right on the accounts. Maybe scroll indicator dots can be good here

@marinofaggiana
Copy link
Member Author

image

It's hard to know you can swipe left and right on the accounts. Maybe scroll indicator dots can be good here

I have make some test and I don't like it (remember the swipe is not essential, in fact, it could easily be omitted)

Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
… into revamp-manageaccount

Signed-off-by: Marino Faggiana <[email protected]>

# Conflicts:
#	iOSClient/Supporting Files/it.lproj/Localizable.strings
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana marinofaggiana requested a review from mpivchev June 20, 2024 16:17
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana marinofaggiana merged commit d3b57b2 into develop Jun 21, 2024
4 checks passed
@marinofaggiana marinofaggiana deleted the revamp-manageaccount branch June 22, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants