Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp Settings Section: Complete Migration to Swift & SwiftUI - Code in Nextcloud / iOS - #2929

Closed
wants to merge 126 commits into from
Closed

Revamp Settings Section: Complete Migration to Swift & SwiftUI - Code in Nextcloud / iOS - #2929

wants to merge 126 commits into from

Conversation

marinofaggiana
Copy link
Member

@marinofaggiana marinofaggiana commented May 20, 2024 •
edited
Loading

#2826

  • Some improvement of code and normalized the GUI

@marinofaggiana
Alignment code
eb6a61e 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
14873b2 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
Settings
dee1aca 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
331c3a0 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
f1727e4 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
98c1f6c 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
940b67a 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
35039dc 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
cleaning
6ee2751 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana marinofaggiana changed the title Settings revamp Revamp Settings Section: Complete Migration to Swift & SwiftUI - Code in Nextcloud / iOS - May 20, 2024
@marinofaggiana
Copy link
Member Author

marinofaggiana commented May 20, 2024 •
edited
Loading

@adityagi02 , @mpivchev continue here the revamp settings.

  • @adityagi02 : please look & fix the NCAutoUploadFileNamesView.swift
  • @adityagi02 : DefaultViewModifier.swift never called (?)

@marinofaggiana marinofaggiana mentioned this pull request May 20, 2024
Closed
21 tasks
@adityagi02
Copy link
Contributor

@adityagi02 , @mpivchev continue here the revamp settings.

  • @adityagi02 : please look & fix the NCAutoUploadFileNamesView.swift
  • @adityagi02 : DefaultViewModifier.swift never called (?)

Yeah, sure. Will work on the review points.

nextcloud-bot and others added 17 commits May 21, 2024 02:30
@nextcloud-bot
Fix(l10n): Update translations from Transifex
624b361 
Signed-off-by: Nextcloud bot <[email protected]>
@marinofaggiana
fic color
d31b039 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
improvements
edf05cc 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
images
e398bad 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
images
a7a092d 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
images
32e2d18 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
Build 17
dd1491a 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
Alignment code
5d8e1be 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
bfe4493 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
Settings
39ff3ba 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
0134b9c 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
158b8c1 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
c6f9c61 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
b7d5099 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
1093c39 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
cleaning
8439978 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
Merge branch 'adityagi02-settings-revamp' of https://github.com/nextc…
c44cef9 
…loud/ios into adityagi02-settings-revamp
@marinofaggiana
coding
56258bc 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
4c55595 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
3a17ac1 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
GUI
01901b2 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
55270f6 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
Add display
2df3a42 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
e65f621 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
9688958 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
8465d2b 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
1e594c4 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
8750cc6 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
cleaning
e975a8a 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
cleaning code
2e852f2 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana marinofaggiana marked this pull request as draft May 31, 2024 15:33
@marinofaggiana
fix db
e175445 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
remove code
88a25c1 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
normalized
937754d 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
normalized
50da0f5 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
normalized
e97203f 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
fix
2b2d3c5 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
ab50b6d 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
5ccf18b 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
yes
7c529ee 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
e74311b 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
lint
d469eca 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
normalized
05dca3e 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana
coding
3ecee5b 
Signed-off-by: Marino Faggiana <[email protected]>
@marinofaggiana marinofaggiana marked this pull request as ready for review June 3, 2024 09:19
@marinofaggiana marinofaggiana deleted the adityagi02-settings-revamp branch June 6, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marinofaggiana @adityagi02 @nextcloud-bot