Enable Login v2 #2908
Merged
Enable Login v2 #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milen Pivchev <[email protected]>
mpivchev
commented
Apr 30, 2024
Brand/NCBrand.swift
Outdated
| @@ -68,7 +68,7 @@ let userAgent: String = { | |||
| @objc public var use_themingColor: Bool = true | |||
| @objc public var use_themingLogo: Bool = false | |||
| @objc public var use_storeLocalAutoUploadAll: Bool = false | |||
| @objc public var use_loginflowv2: Bool = false // Don't touch me !! | |||
| @objc public var use_loginflowv2: Bool = true // Don't touch me !! | |||
There was a problem hiding this comment.
@marinofaggiana The plan is to use v2 by default from now on, and v1 will be obsolete with removal of oldest supported NC version. Maybe we can remove this? Not sure if the brander will break
There was a problem hiding this comment.
yes I created this switch years ago to test v2
There was a problem hiding this comment.
Is it ok to remove it?
Closed
Signed-off-by: Milen Pivchev <[email protected]>
|
Added the option to do the flow via external browser @tobiasKaminsky |
mpivchev
commented
May 2, 2024
iOSClient/Login/NCLoginWeb.swift
Outdated
| @@ -47,6 +47,9 @@ class NCLoginWeb: UIViewController { | |||
| var loginFlowV2Endpoint = "" | |||
| var loginFlowV2Login = "" | |||
|
|
|||
| // Opens the login URL in external browser instead of in app. User must manually go back to the app. | |||
| let loginFlowv2ExternalBrowser = false | |||
There was a problem hiding this comment.
@marinofaggiana Please test with this enabled and disabled
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
marinofaggiana
requested changes
May 15, 2024
iOSClient/Login/NCLoginWeb.swift
Outdated
| NextcloudKit.shared.getLoginFlowV2Poll(token: self.loginFlowV2Token, endpoint: self.loginFlowV2Endpoint) { server, loginName, appPassword, _, error in | ||
| if error == .success, let server, let loginName, let appPassword { | ||
| self.createAccount(server: server, username: loginName, password: appPassword) | ||
| } |
There was a problem hiding this comment.
If error write a message and goBack ?
There was a problem hiding this comment.
I stopped using NCLoginWeb for v2 and this screen stopped appearing. Now we only use NCLogin. NCLoginWeb can be renamed to NCLoginProviders as now only external providers use it.
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
|
@marinofaggiana Please check |
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]> # Conflicts: # iOSClient/Networking/NCNetworking.swift
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]> # Conflicts: # iOSClient/Login/NCLogin.swift # iOSClient/Supporting Files/en.lproj/Localizable.strings
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
…-v2-enable Signed-off-by: Milen Pivchev <[email protected]> # Conflicts: # Brand/NCBrand.swift # Nextcloud.xcodeproj/project.pbxproj # iOSClient/AppDelegate.swift
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables Login v2 and adds support for TLS client certificates.
@marinofaggiana We can remove all v1 code with removal of oldest supported NC version