fix s3 secretKeys.sse_c_key secret key checking typo; now sse_c_key is not required for using s3 with this chart
#631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3 with this chart Signed-off-by: jessebot <[email protected]>
jessebot
changed the title
secretKeys.sse_c_key secret key checking typo; now sse_c_key is not required for using s3 with this chart
provokateurin
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
I did a copypasta typo where I was checking for the s3 bucket parameter instead of the sse c key parameter 🤦 This PR fixes that.
Benefits
Now SSE C won't be required to use this chart with s3 as a primary object store.
Possible drawbacks
none that come to mind, but happy to chat :)
Applicable issues
failed to create resource: [...] spec.template.spec.containers[1].env[22].valueFrom.secretKeyRef.key: Required value]#616Checklist
Chart.yamlaccording to semver.