Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Collabora as a subchart #611 #623

Merged
merged 9 commits into from
Dec 15, 2024

Conversation

kriegalex
Copy link
Contributor

Description of the change

  • Add a dependency to the 1.1.20 collabora chart from their official repository
  • Add the subchart config to values.yaml
  • Add the configuration options documentation to README

Benefits

  • Install collabora as a subchart of nextcloud via helm

Possible drawbacks

  • People may try to enable it without knowing what is is and how to configure it (mainly extra_params, server_name, aliasgroups and annotations.

Applicable issues

Additional information

Tested on my local kubernetes cluster with a HTTPS nginx ingress. Nextcloud can communicate with Collabora. Not tested with HAProxy (though it is only a change in annotations specific to HAProxy).

Checklist

@jessebot
Copy link
Collaborator

Oh, awesome! Thanks, @kriegalex for this PR!

Right now the workflow is failing:
https://github.com/nextcloud/helm/actions/runs/10956242340/job/30421859233?pr=623#step:7:16

You can fix this by adding the helm repo for collabora to this section of the workflow file, similar to how we do for bitnami:

- name: Add dependency chart repos
run: |
helm repo add bitnami https://charts.bitnami.com/bitnami

@jessebot jessebot self-requested a review September 20, 2024 08:57
Copy link
Collaborator

@jessebot jessebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, but we need to ensure the tests still work, so I left a comment about how to update the GHA workflow. If you can, it would also be neat to have a test for collabora itself as well, but we can also hold off on that for a separate PR if you'd like. 🙏

update: added the commit to maybe fix the tests :)

@kriegalex
Copy link
Contributor Author

Thanks for the change on lint tests. I'm still learning k8s, didn't think of that.

@jessebot jessebot self-requested a review December 15, 2024 18:53
@jessebot jessebot dismissed their stale review December 15, 2024 18:53

requested changes done

@jessebot jessebot merged commit 10cae24 into nextcloud:main Dec 15, 2024
9 checks passed
@provokateurin
Copy link
Member

Publishing the release failed: https://github.com/nextcloud/helm/actions/runs/12341432621/job/34440050803

@jessebot
Copy link
Collaborator

looking!

@jessebot
Copy link
Collaborator

jessebot commented Dec 15, 2024

let's see, the error was:

Error: no repository definition for https://collaboraonline.github.io/online

That does seem to be right according to the docs:
https://github.com/CollaboraOnline/online/tree/master/kubernetes/helm/collabora-online#deploying-collabora-online-in-kubernetes

Ah! It's the actual release config that needs to have the collabora online helm repo added:

- name: Add dependency chart repos
run: |
helm repo add bitnami https://charts.bitnami.com/bitnami

PR incoming!

@jessebot
Copy link
Collaborator

jessebot commented Dec 15, 2024

PR to fix release here: #667

PR to release this change here: #668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Collabora as a subchart
3 participants