Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextcloud): add support of imaginary an externalPreviewProvider #622

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

wrenix
Copy link
Collaborator

@wrenix wrenix commented Aug 17, 2024

Description of the change

Benefits

  • faster image rendering for preview
  • nextcloud container is not killed (e.g. OOM) if big and much preview images are generated

Possible drawbacks

Works for me.

TODO:

  • write CI test

Checklist

@wrenix wrenix force-pushed the feat/imaginary branch 5 times, most recently from 6ace176 to 44beda3 Compare August 17, 2024 01:32
@wrenix wrenix marked this pull request as ready for review August 17, 2024 01:48
@wrenix wrenix force-pushed the feat/imaginary branch 2 times, most recently from 04d871c to 5b0fc90 Compare September 6, 2024 07:29
@wrenix
Copy link
Collaborator Author

wrenix commented Sep 11, 2024

ping @jessebot / @provokateurin do you like to review?

@provokateurin
Copy link
Member

Sorry, I don't have the time for that atm. I hope I can do it at some point, but only at the beginning of next month the earliest.

@jessebot
Copy link
Collaborator

jessebot commented Sep 20, 2024

oh this is neat! May I ask what the difference between this and the preview generator app are? (I'm not against it btw, just want to learn more) I will review this more thoroughly as soon as I have a moment 🙏

@wrenix wrenix requested a review from jessebot September 21, 2024 10:15
@wrenix wrenix self-assigned this Sep 21, 2024
Copy link
Collaborator

@jessebot jessebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this! Perhaps we can add another PR for adding a CI test of some sort in the future?

@SIMULATAN
Copy link

Thank you for working on this 🚀
Just wanted to point out that, with Nextcloud 30, the OC\Preview\Imaginary provider no longer generates PDF previews. It may be worth considering adding the new ImaginaryPDF provider to the Imaginary notes in the README.md file.
See https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_30.html#previews-for-pdf-files-with-imaginary
Thanks again, looking forward to using it to speed up my (terribly slow) Nextcloud media previewing ❤️

@wrenix
Copy link
Collaborator Author

wrenix commented Sep 28, 2024

rebased on main and add docu in e393d90 like @SIMULATAN suggested

@wrenix wrenix force-pushed the feat/imaginary branch 3 times, most recently from 3f7a295 to 687f8b9 Compare October 11, 2024 21:09
@wrenix
Copy link
Collaborator Author

wrenix commented Oct 11, 2024

rebased, squashed und test added

@wrenix wrenix force-pushed the feat/imaginary branch 3 times, most recently from fb41953 to 3613d83 Compare November 12, 2024 00:45
@wrenix
Copy link
Collaborator Author

wrenix commented Nov 22, 2024

I found the bug, in the container (why setup of test does not run) ....

So here are the test online.

@wrenix wrenix force-pushed the feat/imaginary branch 7 times, most recently from 3dbdd53 to 404383f Compare November 22, 2024 14:17
@wrenix wrenix requested a review from provokateurin November 22, 2024 14:17
@wrenix
Copy link
Collaborator Author

wrenix commented Dec 13, 2024

rebased / updated - still ready to merge

@wrenix wrenix force-pushed the feat/imaginary branch 4 times, most recently from 4c2c5e8 to 63796c0 Compare December 17, 2024 16:58
@wrenix
Copy link
Collaborator Author

wrenix commented Dec 17, 2024

rebased

Copy link
Collaborator

@jessebot jessebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, you can merge this now! (sorry for the extreme delay 🙇 )

@wrenix wrenix enabled auto-merge December 17, 2024 17:48
@wrenix wrenix merged commit be60e91 into nextcloud:main Dec 17, 2024
10 checks passed
@wrenix wrenix deleted the feat/imaginary branch December 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants