Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mariadb.global.defaultStorageClass to values.yaml #607

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jessebot
Copy link
Collaborator

@jessebot jessebot commented Jul 26, 2024

Description of the change

Add mariadb.global.defaultStorageClass to our values.yaml and clean up the README to also include mariadb.primary.persistence.storageClass and mariadb.primary.persistence.existingClaim as they'd be common parameters.

Benefits

Less confusion about how to use the MariaDB subchart because it better reflects the bitnami helm chart.

Possible drawbacks

none that I can think of, but always happy for feedback :)

Applicable issues

Additional information

nope

Checklist

@jessebot jessebot added enhancement New feature or request externalDatabase Topics related to external databases, such as mariaDB or PostgreSQL labels Jul 26, 2024
@jessebot jessebot self-assigned this Jul 26, 2024
@jessebot jessebot force-pushed the add-mariadb-values branch from e1aa858 to 5f114a2 Compare July 26, 2024 17:52
@jessebot jessebot force-pushed the add-mariadb-values branch from 5f114a2 to fc2733a Compare July 29, 2024 11:40
@jessebot jessebot merged commit 58d75f9 into nextcloud:main Jul 29, 2024
9 checks passed
@jessebot jessebot deleted the add-mariadb-values branch July 29, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request externalDatabase Topics related to external databases, such as mariaDB or PostgreSQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mariadb persisted replicated pvc doesn't use the same storage class
2 participants