-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upgrade notes in CONTRIBUTING.md
, README.md
, values.yaml
#602
base: main
Are you sure you want to change the base?
Update upgrade notes in CONTRIBUTING.md
, README.md
, values.yaml
#602
Conversation
I could improve this PR by also making a note in the values.yaml for the image.tag parameter as mentioned in #103 if you agree that's a good idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to the latest minor version before upgrading to the next major version should probably also be documented: https://docs.nextcloud.com/server/latest/admin_manual/maintenance/upgrade.html#approaching-upgrades
This is not only for creating PRs to update the default version but also for the people who deploy the updates.
Yeah that would be nice too, just to prevent people ending up in broken states... |
Wait, the docs are confusing, due to grammar:
If it's what you're saying here:
Then shouldn't it be this?:
If I can find the repo I need to change this in, I can go update that grammar 🤷 Happy to document that here as well though :) |
b4b6f22
to
a6e0d90
Compare
CONTRIBUTING.md
, README.md
, values.yaml
Yes that sounds wrong indeed, you can fix it in https://github.com/nextcloud/documentation |
PR here :) nextcloud/documentation#12062 |
Signed-off-by: Jesse Hitch <[email protected]> Signed-off-by: jessebot <[email protected]>
a6e0d90
to
b1aef0d
Compare
Description of the change
Adds a section about upgrades to clarify we should only do one major version at a time.
Benefits
just a little doc change to prevent gotchya :)
Possible drawbacks
open to feedback but I think this is minor enough that it's fine.
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.